search

hpe-storage / nimble-ansible-modules

HPE Nimble Storage Ansible Modules
https://hpe-storage.github.io/nimble-ansible-modules
GNU General Public License v3.0
2 stars 7 forks source link

Sanity tests failing in hpe.nimble #54

Open dmsimard opened 2 years ago

dmsimard commented 2 years ago
SUMMARY

We are running sanity tests across every collection included in the Ansible community package (as part of this issue) and found that ansible-test sanity --docker against hpe.nimble 1.1.4 fails with ansible-core 2.13.0rc1 in ansible 6.0.0a2.

ISSUE TYPE
COMPONENT NAME

n/a

ANSIBLE VERSION
ansible [core 2.13.0rc1]
COLLECTION VERSION
1.1.4
STEPS TO REPRODUCE
ansible-test sanity --docker
EXPECTED RESULTS

Tests are either passing or ignored.

ACTUAL RESULTS
ERROR: Found 23 compile issue(s) on python 2.7 which need to be resolved:
ERROR: plugins/module_utils/hpe_nimble.py:171:66: SyntaxError: raise Exception(f"Invalid value for volume {vol_name}")
ERROR: plugins/modules/hpe_nimble_access_control_record.py:125:97: SyntaxError: return (False, False, f"Initiator Group '{initiator_group}' is not present on array.", {})
ERROR: plugins/modules/hpe_nimble_array.py:199:81: SyntaxError: return (True, True, f"Created array '{array_name}' successfully.", {}, array_resp.attrs)
ERROR: plugins/modules/hpe_nimble_chap_user.py:123:80: SyntaxError: return (True, True, f"Chap user '{user_name}' created successfully.", {}, user_resp.attrs)
ERROR: plugins/modules/hpe_nimble_disk.py:116:115: SyntaxError: return (True, True, f"Successfully updated disk to slot '{slot}' at shelf location '{shelf_location}'.", changed_attrs_dict, disk_resp)
ERROR: plugins/modules/hpe_nimble_encryption.py:150:82: SyntaxError: return (True, True, f"Master key '{master_key}' created successfully.", {}, master_key_resp.attrs)
ERROR: plugins/modules/hpe_nimble_fc.py:146:100: SyntaxError: return (False, False, f"No fibre channel is present for array '{array_name_or_serial}'.", {}, {})
ERROR: plugins/modules/hpe_nimble_group.py:547:97: SyntaxError: return (False, False, f"Group '{group_name}' cannot be updated as it is not present.", {}, {})
ERROR: plugins/modules/hpe_nimble_info.py:626:84: SyntaxError: msg = f"Subset name '{key}' is not valid. Please provide a correct subset name."
ERROR: plugins/modules/hpe_nimble_initiator_group.py:159:97: SyntaxError: return (True, True, f"Created initiator Group '{initiator_group_name}' successfully.", {}, ig_resp.attrs)
ERROR: plugins/modules/hpe_nimble_network.py:193:80: SyntaxError: return (True, True, f"Network config '{name}' created successfully.", {}, network_resp.attrs)
ERROR: plugins/modules/hpe_nimble_partner.py:210:100: SyntaxError: return (True, True, f"Replication partner '{downstream_hostname}' created successfully.", {}, upstream_repl_resp.attrs)
ERROR: plugins/modules/hpe_nimble_performance_policy.py:159:100: SyntaxError: return (True, True, f"Created performance policy '{perf_policy_name}' successfully.", {}, perf_policy_resp.attrs)
ERROR: plugins/modules/hpe_nimble_pool.py:141:79: SyntaxError: return (True, True, f"Created pool '{pool_name}' successfully.", {}, pool_resp.attrs)
ERROR: plugins/modules/hpe_nimble_protection_schedule.py:234:99: SyntaxError: return (True, True, f"Created protection schedule '{prot_schedule_name}' successfully.", {}, prot_schedule_resp.attrs)
ERROR: plugins/modules/hpe_nimble_protection_template.py:176:99: SyntaxError: return (True, True, f"Protection template '{prot_template_name}' created successfully.", {}, prot_template_resp.attrs)
ERROR: plugins/modules/hpe_nimble_shelf.py:114:91: SyntaxError: return (False, False, f"Shelf serial '{shelf_serial}' is not present on array.", {})
ERROR: plugins/modules/hpe_nimble_snapshot.py:155:98: SyntaxError: return (False, False, f"Volume '{vol_name}' not present on array for taking snapshot.", {}, {})
ERROR: plugins/modules/hpe_nimble_snapshot_collection.py:182:133: SyntaxError: return (True, True, f"Created snapshot collection '{snapcoll_name}' for volume collection '{volcoll_name}' successfully.", {}, snapcoll_resp.attrs)
ERROR: plugins/modules/hpe_nimble_user.py:163:75: SyntaxError: return (True, True, f"User '{user_name}' created successfully.", {}, user_resp.attrs)
ERROR: plugins/modules/hpe_nimble_user_policy.py:124:117: SyntaxError: return (True, True, f"Updated user policy successfully with following attributes '{changed_attrs_dict}'.", changed_attrs_dict, user_resp.attrs)
ERROR: plugins/modules/hpe_nimble_volume.py:345:77: SyntaxError: return (False, False, f"Volume '{vol_name}' not present to move.", {}, {})
ERROR: plugins/modules/hpe_nimble_volume_collection.py:305:91: SyntaxError: return (True, True, f"Created volume collection '{volcoll_name}' successfully.", {}, volcoll_resp.attrs)
ERROR: Found 23 compile issue(s) on python 3.5 which need to be resolved:
ERROR: plugins/module_utils/hpe_nimble.py:171:66: SyntaxError: raise Exception(f"Invalid value for volume {vol_name}")
ERROR: plugins/modules/hpe_nimble_access_control_record.py:125:97: SyntaxError: return (False, False, f"Initiator Group '{initiator_group}' is not present on array.", {})
ERROR: plugins/modules/hpe_nimble_array.py:199:81: SyntaxError: return (True, True, f"Created array '{array_name}' successfully.", {}, array_resp.attrs)
ERROR: plugins/modules/hpe_nimble_chap_user.py:123:80: SyntaxError: return (True, True, f"Chap user '{user_name}' created successfully.", {}, user_resp.attrs)
ERROR: plugins/modules/hpe_nimble_disk.py:116:115: SyntaxError: return (True, True, f"Successfully updated disk to slot '{slot}' at shelf location '{shelf_location}'.", changed_attrs_dict, disk_resp)
ERROR: plugins/modules/hpe_nimble_encryption.py:150:82: SyntaxError: return (True, True, f"Master key '{master_key}' created successfully.", {}, master_key_resp.attrs)
ERROR: plugins/modules/hpe_nimble_fc.py:146:100: SyntaxError: return (False, False, f"No fibre channel is present for array '{array_name_or_serial}'.", {}, {})
ERROR: plugins/modules/hpe_nimble_group.py:547:97: SyntaxError: return (False, False, f"Group '{group_name}' cannot be updated as it is not present.", {}, {})
ERROR: plugins/modules/hpe_nimble_info.py:626:84: SyntaxError: msg = f"Subset name '{key}' is not valid. Please provide a correct subset name."
ERROR: plugins/modules/hpe_nimble_initiator_group.py:159:97: SyntaxError: return (True, True, f"Created initiator Group '{initiator_group_name}' successfully.", {}, ig_resp.attrs)
ERROR: plugins/modules/hpe_nimble_network.py:193:80: SyntaxError: return (True, True, f"Network config '{name}' created successfully.", {}, network_resp.attrs)
ERROR: plugins/modules/hpe_nimble_partner.py:210:100: SyntaxError: return (True, True, f"Replication partner '{downstream_hostname}' created successfully.", {}, upstream_repl_resp.attrs)
ERROR: plugins/modules/hpe_nimble_performance_policy.py:159:100: SyntaxError: return (True, True, f"Created performance policy '{perf_policy_name}' successfully.", {}, perf_policy_resp.attrs)
ERROR: plugins/modules/hpe_nimble_pool.py:141:79: SyntaxError: return (True, True, f"Created pool '{pool_name}' successfully.", {}, pool_resp.attrs)
ERROR: plugins/modules/hpe_nimble_protection_schedule.py:234:99: SyntaxError: return (True, True, f"Created protection schedule '{prot_schedule_name}' successfully.", {}, prot_schedule_resp.attrs)
ERROR: plugins/modules/hpe_nimble_protection_template.py:176:99: SyntaxError: return (True, True, f"Protection template '{prot_template_name}' created successfully.", {}, prot_template_resp.attrs)
ERROR: plugins/modules/hpe_nimble_shelf.py:114:91: SyntaxError: return (False, False, f"Shelf serial '{shelf_serial}' is not present on array.", {})
ERROR: plugins/modules/hpe_nimble_snapshot.py:155:98: SyntaxError: return (False, False, f"Volume '{vol_name}' not present on array for taking snapshot.", {}, {})
ERROR: plugins/modules/hpe_nimble_snapshot_collection.py:182:133: SyntaxError: return (True, True, f"Created snapshot collection '{snapcoll_name}' for volume collection '{volcoll_name}' successfully.", {}, snapcoll_resp.attrs)
ERROR: plugins/modules/hpe_nimble_user.py:163:75: SyntaxError: return (True, True, f"User '{user_name}' created successfully.", {}, user_resp.attrs)
ERROR: plugins/modules/hpe_nimble_user_policy.py:124:117: SyntaxError: return (True, True, f"Updated user policy successfully with following attributes '{changed_attrs_dict}'.", changed_attrs_dict, user_resp.attrs)
ERROR: plugins/modules/hpe_nimble_volume.py:345:77: SyntaxError: return (False, False, f"Volume '{vol_name}' not present to move.", {}, {})
ERROR: plugins/modules/hpe_nimble_volume_collection.py:305:91: SyntaxError: return (True, True, f"Created volume collection '{volcoll_name}' successfully.", {}, volcoll_resp.attrs)
ERROR: Found 23 import issue(s) on python 2.7 which need to be resolved:
ERROR: plugins/module_utils/hpe_nimble.py:171:66: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_access_control_record.py:125:97: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_array.py:199:81: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_chap_user.py:123:80: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_disk.py:116:115: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_encryption.py:150:82: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_fc.py:146:100: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_group.py:547:97: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_info.py:626:84: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_initiator_group.py:159:97: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_network.py:193:80: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_partner.py:210:100: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_performance_policy.py:159:100: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_pool.py:141:79: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_protection_schedule.py:234:99: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_protection_template.py:176:99: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_shelf.py:114:91: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_snapshot.py:155:98: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_snapshot_collection.py:182:133: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_user.py:163:75: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_user_policy.py:124:117: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_volume.py:345:77: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_volume_collection.py:305:91: traceback: SyntaxError: invalid syntax
ERROR: Found 23 import issue(s) on python 3.5 which need to be resolved:
ERROR: plugins/module_utils/hpe_nimble.py:171:66: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_access_control_record.py:125:97: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_array.py:199:81: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_chap_user.py:123:80: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_disk.py:116:115: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_encryption.py:150:82: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_fc.py:146:100: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_group.py:547:97: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_info.py:626:84: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_initiator_group.py:159:97: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_network.py:193:80: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_partner.py:210:100: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_performance_policy.py:159:100: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_pool.py:141:79: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_protection_schedule.py:234:99: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_protection_template.py:176:99: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_shelf.py:114:91: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_snapshot.py:155:98: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_snapshot_collection.py:182:133: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_user.py:163:75: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_user_policy.py:124:117: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_volume.py:345:77: traceback: SyntaxError: invalid syntax
ERROR: plugins/modules/hpe_nimble_volume_collection.py:305:91: traceback: SyntaxError: invalid syntax
ERROR: Found 22 validate-modules issue(s) which need to be resolved:
ERROR: plugins/modules/hpe_nimble_access_control_record.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_array.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_chap_user.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_disk.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_encryption.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_fc.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_group.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_info.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_initiator_group.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_network.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_partner.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_performance_policy.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_pool.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_protection_schedule.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_protection_template.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_shelf.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_snapshot.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_snapshot_collection.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_user.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_user_policy.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_volume.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_volume_collection.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: The 5 sanity test(s) listed below (out of 43) failed. See error output above for details.
compile --python 2.7
compile --python 3.5
import --python 2.7
import --python 3.5
validate-modules
ERROR: Command "podman exec ansible-test-controller-rNkM2Xlx /usr/bin/env ANSIBLE_TEST_CONTENT_ROOT=/root/ansible_collections/hpe/nimble LC_ALL=en_US.UTF-8 /usr/bin/python3.10 /root/ansible/bin/ansible-test sanity --containers '{}' --skip-test pylint --metadata tests/output/.tmp/metadata-pm4ib60v.json --truncate 0 --color no --host-path tests/output/.tmp/host-zc735c4c" returned exit status 1.