search

hpe-storage / nimble-ansible-modules

HPE Nimble Storage Ansible Modules
https://hpe-storage.github.io/nimble-ansible-modules
GNU General Public License v3.0
2 stars 7 forks source link

ansible-test sanity issues #61

Open mariolenz opened 1 year ago

mariolenz commented 1 year ago

ansible-test sanity seems to fail with:

ERROR: Found 1 pep8 issue(s) which need to be resolved:
ERROR: plugins/modules/hpe_nimble_info.py:692:14: E275: missing whitespace after keyword

and

ERROR: Found 25 validate-modules issue(s) which need to be resolved:
ERROR: plugins/modules/hpe_nimble_access_control_record.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_array.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_chap_user.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_disk.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_encryption.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_fc.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_group.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_info.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_initiator_group.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_network.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_partner.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_performance_policy.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_pool.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_protection_schedule.py:0:0: doc-default-does-not-match-spec: Argument 'at_time' in argument_spec defines default as (None) but documentation defines default as (0)
ERROR: plugins/modules/hpe_nimble_protection_schedule.py:0:0: doc-default-does-not-match-spec: Argument 'num_retain_replica' in argument_spec defines default as (None) but documentation defines default as (0)
ERROR: plugins/modules/hpe_nimble_protection_schedule.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_protection_template.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_shelf.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_snapshot.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_snapshot_collection.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_user.py:0:0: doc-default-does-not-match-spec: Argument 'inactivity_timeout' in argument_spec defines default as (None) but documentation defines default as (0)
ERROR: plugins/modules/hpe_nimble_user.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_user_policy.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_volume.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module
ERROR: plugins/modules/hpe_nimble_volume_collection.py:0:0: missing-gplv3-license: GPLv3 license header not found in the first 20 lines of the module

Since this collection is part the Ansible (community) package 8, please make sure that the sanity tests succeed with ansible-core 2.15.x that it is based on.

BTW: There seem to be no sanity tests since 2 years. However, I think we kind of require them regurarly. See CI Testing for more information.

In case you fix this, please do a new release. The community package includes collections via galaxy (I think) so just fixing this in your repo doesn't really help us.