search

hpe-storage / python-hpedockerplugin

HPE Native Docker Plugin
Apache License 2.0
36 stars 64 forks source link

Fix for lost volume mounts after node reboot #650

Closed kfeh closed 5 years ago

kfeh commented 5 years ago

This Pull Request resolves our Issue #641 We tested this fix on serveral hosts and the issue is resolved!

We fixed the issue in the braches plugin_v2 and v300. If the fix should be applied to other branches, please do this on your own.

wdurairaj commented 5 years ago

there are UT and pep8 failures as shown in the travis ci build. Request @kfeh to investigate and fix this.

kfeh commented 5 years ago

What do you mean by UT failures?

wdurairaj commented 5 years ago

@kfeh , UT -> unit tests check this log https://travis-ci.com/hpe-storage/python-hpedockerplugin/builds/115421688 available in the third tab of this pull request page.

kfeh commented 5 years ago

Pep8 is fixed. Unit Tests is a bit strange... I just copied the code of a exisiting method "mount_dir" and reused it including the exception-handling. So there cannot be any error on the new method... Do you know what is meant by: ('hpeplugin_driver do_setup failed, error is: %s', 'catching classes that do not inherit from BaseException is not allowed')

kfeh commented 5 years ago

Ok, Build is now green!