search

hpe-storage / python-hpedockerplugin

HPE Native Docker Plugin
Apache License 2.0
36 stars 64 forks source link

Fix for issue #680 #684

Closed imran-ansari closed 5 years ago

imran-ansari commented 5 years ago

@wdurairaj , @nilangekarss , please review the changes

nilangekarss commented 5 years ago

@imran-ansari I am okay with this changes if basic testing for default volume creation is done . Code looks fine for me.

imran-ansari commented 5 years ago

@imran-ansari I am okay with this changes if basic testing for default volume creation is done . Code looks fine for me.

Tested basic CRD, mount, unmount, operations along with invalid CPG TC

wdurairaj commented 5 years ago

Pending review comment is on the UT which can be addressed in different PR. Considering this is the going in a final RC build. Merging.