search

hpe-storage / python-hpedockerplugin

HPE Native Docker Plugin
Apache License 2.0
36 stars 64 forks source link

Inventory host file when contains multiple masters fails to copy dory config file #686

Closed sneharai4 closed 5 years ago

sneharai4 commented 5 years ago

Below lines of code needs to be changed where we are pointing to the first host only under [masters] section of the host file. This is not correct when user has multiple masters. Example: [masters] 192.168.20.1 192.168.20.2 192.168.20.3

https://github.com/hpe-storage/python-hpedockerplugin/blob/master/ansible_3par_docker_plugin/tasks/copy_doryd_config.yml#L26

https://github.com/hpe-storage/python-hpedockerplugin/blob/master/ansible_3par_docker_plugin/tasks/copy_doryd_config.yml#L30

https://github.com/hpe-storage/python-hpedockerplugin/blob/master/ansible_3par_docker_plugin/tasks/copy_doryd_config.yml#L37

https://github.com/hpe-storage/python-hpedockerplugin/blob/master/ansible_3par_docker_plugin/tasks/copy_doryd_config.yml#L44

This condition needs to be checked in other places too if any of the other ansible installer task is using only the first IP from masters section.

sneharai4 commented 5 years ago

Fix in https://github.com/hpe-storage/python-hpedockerplugin/pull/691

sneharai4 commented 5 years ago

Fix merged. Closing the issue.