search

hpe-storage / python-hpedockerplugin

HPE Native Docker Plugin
Apache License 2.0
36 stars 64 forks source link

provisioning "thin' and compression "",should result in ERROR instead of creating thin volume #710

Closed c-raghav closed 4 years ago

c-raghav commented 5 years ago

provisioning "thin' and compression "",should result in ERROR instead of creating thin volume

Provisioning Compression Result

thin “” ERROR

c-raghav commented 5 years ago

proisioning ="" and compression "", is resulting in creating thin volume instead of erroring out , this needs to address

c-raghav commented 5 years ago

creating volume with size = "0" or size = o

it still creates volume of size 1024 MB in the backed. But inspect show size = 0

Since we are restricting the case of provisioning ="" and compression "",

This also we need to address, by restricting creation with proper message

bhagyashree-sarawate commented 5 years ago

Assign to me, need discussion with imran

bhagyashree-sarawate commented 4 years ago

Fixed and merged

amitk1977 commented 4 years ago

Raghavendra C to verify and close

c-raghav commented 4 years ago

Verified and find the output below

[root@cssosbe01-196113 hpedockerplugin]# docker volume create -d hpe --name test-defect -o size=10 -o provisioning=thin -o compression="" Error response from daemon: create test-defect: create volume failed, error is: passed compression parameter does not have a valid value. Valid values are: ['true', 'false']

[root@cssosbe01-196113 hpedockerplugin]# docker volume create -d hpe --name test-defect -o size=10 -o provisioning="thin" -o compression="" Error response from daemon: create test-defect: create volume failed, error is: passed compression parameter does not have a valid value. Valid values are: ['true', 'false']

[root@cssosbe01-196113 hpedockerplugin]# docker volume create -d hpe --name test-defect -o size=10 -o provisioning="" -o compression="" Error response from daemon: create test-defect: create volume failed, error is: passed compression parameter does not have a valid value. Valid values are: ['true', 'false']

[root@cssosbe01-196113 hpedockerplugin]# docker volume create -d hpe --name test-defect -o size=0 -o provisioning="thin" Error response from daemon: create test-defect: Please enter the valid integer value for size parameter