search

hpe-storage / python-hpedockerplugin

HPE Native Docker Plugin
Apache License 2.0
36 stars 64 forks source link

Added fix for 704 #727

Closed bhagyashree-sarawate closed 4 years ago

bhagyashree-sarawate commented 5 years ago

Fix for https://github.com/hpe-storage/python-hpedockerplugin/issues/704

bhagyashree-sarawate commented 5 years ago

Hi Modified diff.seconds to diff.total_seconds() and then rounded for getting the integer value since, seconds is the number of seconds within a day, which is in [0, 86399]. total_seconds is the entire timedelta converted to seconds Please review Regards Bhagyashree Sarawate

bhagyashree-sarawate commented 5 years ago

@bhagyashree-sarawate Code changes looks good to me. Could you please attach the tests for this where I can see the expected results in docker volume inspect command.

PFA output for the bug 704 which include import and inspect of a snapshot output_704.txt