hpe-storage / truenas-csp

TrueNAS Container Storage Provider for HPE CSI Driver for Kubernetes
https://scod.hpedev.io
MIT License
65 stars 8 forks source link

TrueNAS Scale compatibility? #21

Closed ishioni closed 2 years ago

ishioni commented 2 years ago

Does this driver work with SCALE as well as CORE?

datamattsson commented 2 years ago

According to iXsystems, TrueNAS SCALE is API compatible with CORE. That said, it boils down to what the LUNs show up as on the host (lsblk -o VENDOR,MODEL). If it enumerates as "TrueNAS" "iSCSI Disk" it should just work. I can give this a whirl in my environment this weekend.

datamattsson commented 2 years ago

I kicked the tires on TrueNAS SCALE. The lights come on if you remove the "hardware_handler" row from the TrueNAS stanza in /etc/multipath.conf. I've raised a PR to have this removed from the stanza. I've elaborated a bit more in the PR.

If the PR gets merged I'll perform some more testing in the next release. It will most likely be towards the end of the year.

ishioni commented 2 years ago

Looks the changes were merged. Good to go now?

datamattsson commented 2 years ago

@ishioni unfortunately not. We need to wait for a new build to get published. There's an imminent beta drop happening and a production released scheduled for early next year. I might start testing with the beta builds. If you're eager to get started, you can easily change the multipath.conf file manually on your worker nodes when the CSI driver has been deployed.

ishioni commented 2 years ago

Nah, that's ok, I'll wait :) I'll give this a spin once i get my new k3os based cluster up anyway

On a completely separate note, would you mind if I submitted a PR integrating the creation of the api secret and Storageclasses as part of values.yaml in the chart? I'm guessing you had a reason not shipping that in the first place?

datamattsson commented 2 years ago

The problem with StorageClass objects is that they're immutable from Helm (or at least was, when we started working on this). We had functionality to provide StorageClass and backend Secrets in the chart at launch but it caused more angst than it was worth in the end, hence we added those steps as post-install steps.

Also, k3os is not something we know if the CSI driver works with yet. Let me explore that.

ishioni commented 2 years ago

Please ignore the k3os part. I've abandoned it in lieu of a k3s+ubuntu setup. Waiting for a version which supports scale, and i'll be happy :)

datamattsson commented 2 years ago

Please give v2.1.0 a whirl and create a new issue if TrueNAS SCALE doesn't work out for you. TrueNAS SCALE 22.02 RC1 passes full CSI e2e tests in my lab with this release of the CSP.

As a side note. I've verified the HPE CSI Driver for Kubernetes works with K3s, not K3os yet though.

ishioni commented 2 years ago

I just switched over, and it works great :)