hpe-storage / truenas-csp

TrueNAS Container Storage Provider for HPE CSI Driver for Kubernetes
https://scod.hpedev.io
MIT License
65 stars 8 forks source link

Not able to pass resources block to chart #47

Closed kingnarmer closed 4 months ago

kingnarmer commented 10 months ago

chart install fails when supplied resources block on values input.

Error:


│ truenas-csp:
│ - resources: Additional property requests is not allowed```

I think the vales.schema.json need to be updated for "resources" section. 

https://github.com/hpe-storage/truenas-csp/blob/1657b8f76aeed99a29e364f8027dccc4734b7a07/helm/charts/truenas-csp/values.schema.json#L344
datamattsson commented 10 months ago

Thanks for reporting this. I'll take a look when I'm back from vacation next week.

On Tue, Oct 24, 2023, 12:58 PM kingnarmer @.***> wrote:

chart install fails when supplied resources block on values input.

Error:

│ truenas-csp: │ - resources: Additional property requests is not allowed```

I think the vales.schema.json need to be updated for "resources" section. https://github.com/hpe-storage/truenas-csp/blob/1657b8f76aeed99a29e364f8027dccc4734b7a07/helm/charts/truenas-csp/values.schema.json#L344

— Reply to this email directly, view it on GitHub https://github.com/hpe-storage/truenas-csp/issues/47, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVTK2AKKW7LO5XC5GSOYXLYA6NMTAVCNFSM6AAAAAA6NQAGDOVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE2TSMBQGAZDEOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

ajchiarello commented 9 months ago

Is there any movement on this?

datamattsson commented 9 months ago

What I can tell from the template values.yaml file is that this block was never taken into consideration and tested in the schema. I'll fix it in the next release.

datamattsson commented 4 months ago

This has been fixed in v2.4.2. Defaults are in values.yaml.