hperrin / svelte-material-ui

Svelte Material UI Components
https://sveltematerialui.com/
Apache License 2.0
3.33k stars 285 forks source link

TypeError: m.getPropStore is not a function on <AutoAdjust {topAppBar}> #573

Closed f0o closed 1 year ago

f0o commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://github.com/hperrin/svelte-material-ui/blob/master/packages/site/src/routes/demo/top-app-bar/iframe/fixed/+page.svelte
  2. Use that in your sveltekit ^1.0.0 application
  3. Build
  4. See error in browser console and a blank page

Expected behavior Example should not error and actually work on latest sveltekit (since sveltekit is now being forced by svelte it seems)

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

f0o commented 1 year ago

Turns out it was ts issue... Closing

quasarchimaere commented 1 year ago

i am not sure if this is a ts issue, i run into the same problem and it is causing the variant class to be missing in the produced main tag created by AutoAdjust -> class="mdc-top-app-bar--short-fixed-adjust" is missing (for variant=short) and thus the navbar is placed above content hiding whats underneath

The workaround for now is that i add the mdc-top-app-bar--short-fixed-adjust class to the AutoAdjust component in my layout directly, which is ok because my variant does not change dynamically, but its still a hack