hpeyerl / venstar_colortouch

Python interface for Venstar ColorTouch thermostats
MIT License
12 stars 22 forks source link

Possibly some extraneous debug statements? #12

Closed flamechair closed 5 years ago

flamechair commented 5 years ago

https://github.com/hpeyerl/venstar_colortouch/blob/dc4f3c0a41c2850e9a67ee30b063c07c2ed478a8/src/venstarcolortouch/venstarcolortouch.py#L228

Would it be possible to remove this print statement? So if the function succeeds we don't see anything, but if it fails we see the error message listed here:

https://github.com/hpeyerl/venstar_colortouch/blob/dc4f3c0a41c2850e9a67ee30b063c07c2ed478a8/src/venstarcolortouch/venstarcolortouch.py#L231

Otherwise everytime you run a command, it starts filling up the log with success messages:

2019-09-06 18:02:00 INFO (MainThread) [homeassistant.setup] Setting up logger
Config directory: /config
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
set_control Success!
hpeyerl commented 5 years ago

Sorry for the delay. Not ignoring you; just busy.

Seems reasonable; if you submit a merge request I'll approve it. Otherwise I can try to do something with it this weekend.

flamechair commented 5 years ago

I'll work on this today or tomorrow.

Thank you,

Tyler Page

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Wednesday, September 11, 2019 11:47 PM, Herb Peyerl notifications@github.com wrote:

Sorry for the delay. Not ignoring you; just busy.

Seems reasonable; if you submit a merge request I'll approve it. Otherwise I can try to do something with it this weekend.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.