search

hpfxd / PandaSpigot

Fork of Paper for 1.8.8 focused on improved performance and stability.
GNU General Public License v3.0
247 stars 68 forks source link

Ensure correct attack damage on slot change #153

Closed ThatApplePieGuy closed 7 months ago

ThatApplePieGuy commented 1 year ago

fixes a vanilla bug where attack damage isnt updated in time if you attack too fast after changing slots. demo: https://youtu.be/QyarG6DSh1c

andreasdc commented 1 year ago

Better change this in held item packet

iamnoksio commented 1 year ago

[00:41:06] [Server thread/WARN]: Failed to handle packet for / java.lang.IllegalArgumentException: Modifier is already applied on this attribute! at net.minecraft.server.v1_7_R4.AttributeModifiable.a(SourceFile:74) ~[spigot.jar:git-PaperSpigot-1f7d532] at net.minecraft.server.v1_7_R4.PlayerConnection.a(PlayerConnection.java:847) ~[spigot.jar:git-PaperSpigot-1f7d532] at net.minecraft.server.v1_7_R4.PacketPlayInHeldItemSlot.a(SourceFile:30) ~[spigot.jar:git-PaperSpigot-1f7d532] at net.minecraft.server.v1_7_R4.PacketPlayInHeldItemSlot.handle(SourceFile:8) ~[spigot.jar:git-PaperSpigot-1f7d532] at net.minecraft.server.v1_7_R4.NetworkManager.a(NetworkManager.java:197) ~[spigot.jar:git-PaperSpigot-1f7d532] at net.minecraft.server.v1_7_R4.ServerConnection.c(ServerConnection.java:73) ~[spigot.jar:git-PaperSpigot-1f7d532] at net.minecraft.server.v1_7_R4.MinecraftServer.v(MinecraftServer.java:799) ~[spigot.jar:git-PaperSpigot-1f7d532] at net.minecraft.server.v1_7_R4.DedicatedServer.v(DedicatedServer.java:319) ~[spigot.jar:git-PaperSpigot-1f7d532] at net.minecraft.server.v1_7_R4.MinecraftServer.u(MinecraftServer.java:652) ~[spigot.jar:git-PaperSpigot-1f7d532] at net.minecraft.server.v1_7_R4.MinecraftServer.run(MinecraftServer.java:566) ~[spigot.jar:git-PaperSpigot-1f7d532] at net.minecraft.server.v1_7_R4.ThreadServerApplication.run(SourceFile:628) ~[spigot.jar:git-PaperSpigot-1f7d532]

ThatApplePieGuy commented 1 year ago

can you reproduce this in 1.8?