hpfxd / PandaSpigot

Fork of Paper for 1.8.8 focused on improved performance and stability.
GNU General Public License v3.0
247 stars 68 forks source link

[SUGGESTION] More knockback settings + knockback profiles #66

Open gabrielvicenteYT opened 1 year ago

gabrielvicenteYT commented 1 year ago

This suggestion might seem like a duplicate from https://github.com/hpfxd/PandaSpigot/issues/28 and https://github.com/hpfxd/PandaSpigot/issues/20, but it is not. The changes that i'd like to be made are:

Seperate Friction into:

Horizontal Friction

Seperate Horizontal into:

Seperate extraHorizontal into:

Seperate Vertical into:

Seperate extraVertical into:

Allow players to have multiple knockback profiles, and an API to allow them to link it to their Practice, or whatever other gamemode plugin, onto!

That's about it for now. (Though i will suggest more later)

PS: I know this is very ambitious, but i want PandaSpigot to be the best spigot ever!

gabrielvicenteYT commented 1 year ago

@hpfxd So, what do you think?

uRyanxD commented 1 year ago

@hpfxd So, what do you think?

"I've been working on a new knockback system on and off for a few months in a local branch, but it has its flaws and needs many changes. I'll try to improve it a bit and publish what I have soon. In my opinion, Nacho's knockback system is limited in some ways I'd like to avoid, and I'd like to provide more control in the API."

iamnoksio commented 1 year ago

This suggestion might seem like a duplicate from #28 and #20, but it is not. The changes that i'd like to be made are:

Seperate Friction into:

Horizontal Friction

  • friction-horizontal
  • friction-horizontal-min
  • friction-horizontal-max Vertical Friction
  • friction-vertical
  • friction-vertical-min
  • friction-vertical-max

Seperate Horizontal into:

  • horizontal
  • horizontal-min
  • horizontal-max

Seperate extraHorizontal into:

  • extra-horizontal
  • extra-horizontal-min
  • extra-horizontal-max

Seperate Vertical into:

  • vertical
  • vertical-min
  • vertical-max

Seperate extraVertical into:

  • extra-vertical
  • extra-vertical-min
  • extra-vertical-max

Allow players to have multiple knockback profiles, and an API to allow them to link it to their Practice, or whatever other gamemode plugin, onto!

That's about it for now. (Though i will suggest more later)

PS: I know this is very ambitious, but i want PandaSpigot to be the best spigot ever!

THE MOST USELESS THING I EVER SEEN

gabrielvicenteYT commented 1 year ago

This suggestion might seem like a duplicate from #28 and #20, but it is not. The changes that i'd like to be made are: Seperate Friction into: Horizontal Friction

  • friction-horizontal
  • friction-horizontal-min
  • friction-horizontal-max Vertical Friction
  • friction-vertical
  • friction-vertical-min
  • friction-vertical-max

Seperate Horizontal into:

  • horizontal
  • horizontal-min
  • horizontal-max

Seperate extraHorizontal into:

  • extra-horizontal
  • extra-horizontal-min
  • extra-horizontal-max

Seperate Vertical into:

  • vertical
  • vertical-min
  • vertical-max

Seperate extraVertical into:

  • extra-vertical
  • extra-vertical-min
  • extra-vertical-max

Allow players to have multiple knockback profiles, and an API to allow them to link it to their Practice, or whatever other gamemode plugin, onto! That's about it for now. (Though i will suggest more later) PS: I know this is very ambitious, but i want PandaSpigot to be the best spigot ever!

THE MOST USELESS THING I EVER SEEN

Not useless, could replace RandomKB, with no KB delay and an API usable by most practice cores (Eden already has support for WindSpigot, for example.)

iamnoksio commented 1 year ago

This suggestion might seem like a duplicate from #28 and #20, but it is not. The changes that i'd like to be made are: Seperate Friction into: Horizontal Friction

  • friction-horizontal
  • friction-horizontal-min
  • friction-horizontal-max Vertical Friction
  • friction-vertical
  • friction-vertical-min
  • friction-vertical-max

Seperate Horizontal into:

  • horizontal
  • horizontal-min
  • horizontal-max

Seperate extraHorizontal into:

  • extra-horizontal
  • extra-horizontal-min
  • extra-horizontal-max

Seperate Vertical into:

  • vertical
  • vertical-min
  • vertical-max

Seperate extraVertical into:

  • extra-vertical
  • extra-vertical-min
  • extra-vertical-max

Allow players to have multiple knockback profiles, and an API to allow them to link it to their Practice, or whatever other gamemode plugin, onto! That's about it for now. (Though i will suggest more later) PS: I know this is very ambitious, but i want PandaSpigot to be the best spigot ever!

THE MOST USELESS THING I EVER SEEN

Not useless, could replace RandomKB, with no KB delay and an API usable by most practice cores (Eden already has support for WindSpigot, for example.)

do you even know how it works??

gabrielvicenteYT commented 1 year ago

This suggestion might seem like a duplicate from #28 and #20, but it is not. The changes that i'd like to be made are: Seperate Friction into: Horizontal Friction

  • friction-horizontal
  • friction-horizontal-min
  • friction-horizontal-max Vertical Friction
  • friction-vertical
  • friction-vertical-min
  • friction-vertical-max

Seperate Horizontal into:

  • horizontal
  • horizontal-min
  • horizontal-max

Seperate extraHorizontal into:

  • extra-horizontal
  • extra-horizontal-min
  • extra-horizontal-max

Seperate Vertical into:

  • vertical
  • vertical-min
  • vertical-max

Seperate extraVertical into:

  • extra-vertical
  • extra-vertical-min
  • extra-vertical-max

Allow players to have multiple knockback profiles, and an API to allow them to link it to their Practice, or whatever other gamemode plugin, onto! That's about it for now. (Though i will suggest more later) PS: I know this is very ambitious, but i want PandaSpigot to be the best spigot ever!

THE MOST USELESS THING I EVER SEEN

Not useless, could replace RandomKB, with no KB delay and an API usable by most practice cores (Eden already has support for WindSpigot, for example.)

do you even know how it works??

No, but I'll check it right now.

gabrielvicenteYT commented 1 year ago

Must be hard, though.

iamnoksio commented 1 year ago

Not that hard just need to understand

gabrielvicenteYT commented 1 year ago

I code a bit, and I'll admit that it takes a while to make a good code base, and to make things work overall.

gabrielvicenteYT commented 1 year ago

Do you have a Discord account? If so, if you may, give me your Discord username and tag.

iamnoksio commented 1 year ago

I'm coding since 2014 and it's not that long and hard also here it is: N O K S I O#9570

gabrielvicenteYT commented 1 year ago

Added you. Coccocoa's Helper#1105