Working repository in context of the bachelor project "Online Marketplace Simulation: A Testbed for Self-Learning Agents" at the research group Enterprise Platform and Integration Concepts
Dear reviewer:
Please just ignore the test_docker_manager.py.
The model files for sim_market and rl are just ordered differently. I inserted logic into on_recommerce_change.py (where we write those files) to prevent shuffeling in the future.
When reviewing I would suggest doing a user test first.
review user test
So open the webserver, go to configuration and change the agent. Observe how the fields in Hyperparameter-RL change.
Test the prefill as well, and do as suggested in the ticket.
review code
For code review, start in webserver/alpha_business_app/views.py:agent_changed.
When done looking at the python code, take a look at webserver/alpha_business_app/static/custom.js:addChangeToAgent
To figure out how we produce code for hyperparameter templates and model files, please consult webserver/alpha_business_app/on_recommerce_change.py
The general approach: we always have all possible config fields available on the website. The ones which are not relevant to this agent are just not visible. Which fields should not be visible is returned by webserver/alpha_business_app/views.py:agent_changed. Adding the "not visible class" is than performed by jquery.
This holds some advantages for us. Can you find them? ;)
It also means, that when sending a dictionary to the docker API, all values will be in there. Please consider if this could cause problems. I am not so sure about that.
Thanks for reviewing :)
Looking forward to your suggestions and thoughts
closes #497 needs review of #518
Dear reviewer: Please just ignore the
test_docker_manager.py. The model files forsim_marketandrlare just ordered differently. I inserted logic intoon_recommerce_change.py(where we write those files) to prevent shuffeling in the future. When reviewing I would suggest doing a user test first. review user test So open the webserver, go toconfigurationand change the agent. Observe how the fields in Hyperparameter-RL change. Test the prefill as well, and do as suggested in the ticket.review code For code review, start in
webserver/alpha_business_app/views.py:agent_changed. When done looking at the python code, take a look atwebserver/alpha_business_app/static/custom.js:addChangeToAgentTo figure out how we produce code for hyperparameter templates and model files, please consultwebserver/alpha_business_app/on_recommerce_change.pyThe general approach: we always have all possible config fields available on the website. The ones which are not relevant to this agent are just not visible. Which fields should not be visible is returned by
webserver/alpha_business_app/views.py:agent_changed. Adding the "not visible class" is than performed by jquery. This holds some advantages for us. Can you find them? ;)It also means, that when sending a dictionary to the docker API, all values will be in there. Please consider if this could cause problems. I am not so sure about that.
Thanks for reviewing :) Looking forward to your suggestions and thoughts