search

hpi-epic / pricewars-consumer

Consumer Component of the Price Wars Platform
MIT License
0 stars 4 forks source link

Remove producer dependency #13

Closed CarstenWalther closed 6 years ago

CarstenWalther commented 6 years ago

The consumer should not need to know about the producer.

I removed the product popularity feature and the product selection based on these popularities. Instead, the buying behaviors get all offers of all product types to choose from.

The api route update_product_details is no longer needed and is removed.

I removed the sigmoid buying behavior because it used product prices from the producer. I tested all other buying behaviors and they worked. We can close issue #8.

Bouncner commented 6 years ago

What does "tested all other buying behaviors and they worked" mean exactly?

CarstenWalther commented 6 years ago

I ran each buying behavior and couldn't reproduce the crash.

Bouncner commented 6 years ago

Ok ... I hoped for "I wrote some tests and they all pass". ;)

Bouncner commented 6 years ago

Can you please update the submodule in the main repo as well?

CarstenWalther commented 6 years ago

I updated the consumer submodule.