Finally! We do no longer have to handle the >1,4k lines long data_functions.js file anymore. I've restructured its contents into the following files:
metric_functions.js → this file contains all the wrapper functions to gather the complete data for our metrics
data_manipulation.js → contains all the functions which manipulate data that was retrieved via any API. Manipulation includes sorting, filtering, selecting the data or constructing any new data objects.
data_utils.js → contains functions that are not relevant to metrics but still include requests to APIs
rest_requests.js → functions that request data from the GitHub REST API
graphql_requests.js → functions that request data from the GitHub GraphQL API
Furthermore, I did some renaming and refactoring to make it easier to understand the code.
Checklist before merge
Developer's responsibilities
[x] Assign one or two developers
[ ] Change code if reviewer(s) has/have requested it
[x] Pull request build has passed
[x] tested locally (in at least chrome & firefox if frontend)
Fixes #57
Changes
Finally! We do no longer have to handle the >1,4k lines long data_functions.js file anymore. I've restructured its contents into the following files:
metric_functions.js→ this file contains all the wrapper functions to gather the complete data for our metricsdata_manipulation.js→ contains all the functions which manipulate data that was retrieved via any API. Manipulation includes sorting, filtering, selecting the data or constructing any new data objects.data_utils.js→ contains functions that are not relevant to metrics but still include requests to APIsrest_requests.js→ functions that request data from the GitHub REST APIgraphql_requests.js→ functions that request data from the GitHub GraphQL APIFurthermore, I did some renaming and refactoring to make it easier to understand the code.
Checklist before merge
Developer's responsibilities