hpi-sam / ask-your-repository-api

This service provides an api to store artefacts with their related meta-data and tags and performs machine learning on them
MIT License
5 stars 2 forks source link

Use Neomodel instead of py2neo. [FEEDBACK WANTED] #61

Closed Askir closed 5 years ago

Askir commented 5 years ago

This is how Neomodel would work.

But in general I think the library is quite a bit better. It also has the ability to have Models for Relationships so we are able to save properties in the "TAGGED_WITH" Relationship for example. Which is really nice imo and was definitely missing in py2neo.

The interface isn't perfect. For some reason the interal neo id is exposed as .id which is really annoying because now we have to use id_ again to save our own uuid. But at least they provide an easy property for that yay!

Some other things that made me stumble:

Askir commented 5 years ago

Pipeline broke I know it's just a spike PR so everyone can see how it would look like. I didn't delete all references to py2neo yet sorry.

Askir commented 5 years ago

@erksch would there be any problems in the frontend if from now on we would ommit the hyphens in uuids?

Askir commented 5 years ago

E2E is fixed with this PR in Jona: https://github.com/hpi-sam/ask-your-repository-web/pull/42 just waiting for eriks approval.

I know this is a huge PR again but I'd really appreciate reviews at least on a basic level. To make sure everybody understands what this was about and also to make sure I didn't miss any obvious problems

erksch commented 5 years ago

@Askir There would be now problem whatsoever in the frontend. If the ID is consistent in all resources everything will work

erksch commented 5 years ago

@Askir Great work overall! Well tested imo.