hpi-schul-cloud / gamification

A reusable microservice for gamification.
GNU Affero General Public License v3.0
45 stars 18 forks source link

Change YAML name format #51

Closed frederike-ramin closed 6 years ago

frederike-ramin commented 6 years ago

I always struggle when writing our yaml, so I changed the syntax a little. For now only with achievements:

achievement:
         name: XYZ
         amount: 1

instead of

achievement: XYZ
        amount: 1

To be consistent, I'd also like to change that with xp requirements, but first wanted to hear your opinion on this.

cmfcmf commented 6 years ago

To be consistent, I'd also like to change that with xp requirements, but first wanted to hear your opinion on this.

Yes, please!! I'm 💯% for this change. As discussed, we could later™ introduce a config normaliser which normalises achievement: 'blah' to achievement: {name: 'blah'}.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 24


Totals Coverage Status
Change from base Build 22: 0.0%
Covered Lines: 258
Relevant Lines: 262

💛 - Coveralls