hpi-schul-cloud / gamification

A reusable microservice for gamification.
GNU Affero General Public License v3.0
44 stars 17 forks source link

Use `path.join` when handling file paths #66

Closed cmfcmf closed 5 years ago

cmfcmf commented 5 years ago

@corinnaj I've extracted this change from #62 and also expanded it to the tests, as suggested.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 97


Totals Coverage Status
Change from base Build 93: 0.0%
Covered Lines: 297
Relevant Lines: 301

💛 - Coveralls
cmfcmf commented 5 years ago

There even is an eslint rule for this: eslint.org/docs/rules/no-path-concat, we could consider enabling that

Good idea, @corinnaj! I've activated the rule in 80397d8. @frederike-ramin the rule's docs also give some more information on why it makes sense to use path.join: https://eslint.org/docs/rules/no-path-concat