search

hpi-schul-cloud / meta-search-engine

This is a meta search engine to join the forces of several Schul-Cloud search engines
GNU Affero General Public License v3.0
0 stars 2 forks source link

fix travis tests #4

Closed niccokunzmann closed 7 years ago

niccokunzmann commented 7 years ago

Currenty, the travis tests are failing: https://travis-ci.org/schul-cloud/meta-search-engine Please fix that.

Idea:

suknuk commented 7 years ago

Hello, I changed the .travis.yml file according to your idea. I was however unable transform the after_failure part to display the access/error logs from the docker container. Can you tell me if everything is okay for a pull request or do you want me to change something in the travis file?

niccokunzmann commented 7 years ago

Hi @suknuk, this looks good. Would you like to create a pull-request?

I do not know if getting this after failure files running is important. I think, the server should print out everything into the docker log. These files should not be used as I would expect the command

docker log meta-search-engine-container

to display all information. (It could also be docker logs, maybe docker start instead of docker run .. I do not know :) ). What do you think?

suknuk commented 7 years ago

Hello @niccokunzmann, I just started using Docker, so I am not at all an expert, but I believe the order for Docker containers is the following:

docker run --name [NAME] [CONTAINER]
docker stop [NAME]
docker start [NAME]

I also added the docker logs in case of failure for the Travis tests in the pull request

niccokunzmann commented 7 years ago

@suknuk Thanks, I am really greatful. I tried a lot to get the tests running natively but it did not work. If you like to contribute further, I invite you to: https://github.com/schul-cloud/meta-search-engine/invitations We have a rule that we do not merge our own pull-requests.

The meta-search-engine is part of a greater project to scale up the content search: https://github.com/schul-cloud/schulcloud-content/projects/1 and this issue is the reason why it was created: https://github.com/schul-cloud/schulcloud-content/issues/2

I should write this into the README^^

Let me know if you need anything else or if I can help somewhere. You can still comment if I close, I think.

suknuk commented 7 years ago

Thanks @niccokunzmann, Even though I have no experience in php, I would like to try to resolve Issue #2. Currently on Travis and my local machine, the following command:

curl -i 'http://localhost:8000/?Q=einstein'

results in no actual data being returned result Ideally, I would like to see some data being returned before beginning to work on the issue - any idea how I could achieve this?

niccokunzmann commented 7 years ago

Let's talk in #2 about it.