Correctly dispose SignedInScreen on logout

hpi-schul-cloud / schulcloud-flutter

Our Flutter based App for Android and iOS.

GNU Affero General Public License v3.0

20 stars 3 forks source link

Correctly dispose SignedInScreen on logout #241

Closed JonasWanke closed 4 years ago

JonasWanke commented 4 years ago

Closes: #183, closes: #237

When we called pushReplacementNamed on sign-out, we only replaced the AccountDialog that was still opened. Therefore, the old SignedInScreen remained open, which lead to various bugs:

183: The old SignedInScreen was rebuilt after signing out, but no token was available.
237: Somehow, the old state was still kept. This led to GlobalKeys being used multiple times and also old routes being reopened even when signing in with a different account.

unicorn-bot commented 4 years ago

:heavy_check_mark: Unicorn Report

:information_source: 1 Info

This PR will close the following issues: #183, #237

Generated by :unicorn: Unicorn
_{Report an issue}

github-actions[bot] commented 4 years ago

Flutter Analyze found 0 issues ✅

Generated by :no_entry_sign: Danger

hpi-schul-cloud / schulcloud-flutter

Correctly dispose SignedInScreen on logout #241

183: The old `SignedInScreen` was rebuilt after signing out, but no token was available.

237: Somehow, the old state was still kept. This led to `GlobalKey`s being used multiple times and also old routes being reopened even when signing in with a different account.

:heavy_check_mark: Unicorn Report

:information_source: 1 Info

Flutter Analyze found 0 issues ✅

hpi-schul-cloud / schulcloud-flutter

Correctly dispose SignedInScreen on logout #241

183: The old SignedInScreen was rebuilt after signing out, but no token was available.

237: Somehow, the old state was still kept. This led to GlobalKeys being used multiple times and also old routes being reopened even when signing in with a different account.

:heavy_check_mark: Unicorn Report

:information_source: 1 Info

Flutter Analyze found 0 issues ✅

183: The old `SignedInScreen` was rebuilt after signing out, but no token was available.

237: Somehow, the old state was still kept. This led to `GlobalKey`s being used multiple times and also old routes being reopened even when signing in with a different account.