Minor mistakes in Chapters 8 and 9

hpi-swa-lab / SqueakByExample-english

An introductory book about the Squeak/Smalltalk programming system, guiding students and developers through the environment, language, tools, and the Morphic framework by means of a series of examples and exercises.

https://www.lulu.com/shop/patrick-rein-and-christoph-thiede/squeak-by-example-60/paperback/product-8vr2j2.html

Other

24 stars 6 forks source link

Minor mistakes in Chapters 8 and 9 #100

Closed Vrabbers closed 1 year ago

Vrabbers commented 3 years ago

In section 8.1, page 178, the explanation for the code snippet mentions Object>>deepCopy:, but its snippet uses veryDeepCopy.

In the very end of 9.6, page 214, the code snippet provided for anySatisfy: and gather: are the same.

LinqLover commented 3 years ago

Thanks a lot for filing these issues, @Vrabbers!

Proposed solutions

For the deep copying, I think the text is wrong. Iirc #deepCopy has no cycle protection whereas #veryDeepCopy has?

For #gather:, I would propose the following example instead:

colors gather: [:color | color names] --> #(#white #snow #yellow #lemon #red #maraschino #blue #blueberry #orange)

@codeZeilen If you agree with these proposals, I'll be glad to submit a PR. :-)

LinqLover commented 1 year ago

@codeZeilen Please reply with a comment for approval in the future, I missed that because GitHub doesn't notify me about reactions 😅