hpi-swa-lab / SqueakByExample-english

An introductory book about the Squeak/Smalltalk programming system, guiding students and developers through the environment, language, tools, and the Morphic framework by means of a series of examples and exercises.
https://www.lulu.com/shop/patrick-rein-and-christoph-thiede/squeak-by-example-60/paperback/product-8vr2j2.html
Other
25 stars 7 forks source link

New diagram files for Models and Collections chapter #57

Closed codeZeilen closed 3 years ago

codeZeilen commented 3 years ago

@LinqLover the Models files are the stripped versions without the screenshot embedded. Feel free to rename them. I will continue on another PR.

LinqLover commented 3 years ago

@codeZeilen Why are there multiple files for each diagram? Can't we eliminate some of them by writing a proper CI script?

LinqLover commented 3 years ago

image

Hm ...

codeZeilen commented 3 years ago

@codeZeilen Why are there multiple files for each diagram? Can't we eliminate some of them by writing a proper CI script?

Unfortunately not really, the visio file is the new ground truth but can not be used in the latex file. One of the svg and png files can be removed as soon as we settled for a good way to combine them with the screenshot.

codeZeilen commented 3 years ago

image

Hm ...

Yes, the joys of LaTeX. Is that the png or the svg? As far as I remember transparent PNGs are only supported by the latest pdflatex version.

LinqLover commented 3 years ago

Unfortunately not really, the visio file is the new ground truth but can not be used in the latex file.

https://sourceforge.net/projects/vdxtosvg/ or maybe http://dia-installer.de/vsd2svg/index.html.en might work, but I'm not sure whether it would be worth the effort.

image Hm ...

Yes, the joys of LaTeX. Is that the png or the svg? As far as I remember transparent PNGs are only supported by the latest pdflatex version.

This is what you committed. :-) It looks as if the PNG version has won, I will prefer SVG anyway ... (Still strange because the CI uses a docker image for texlive)

Btw, the legend arrows are missing in both PNG + SVG.

LinqLover commented 3 years ago

@codeZeilen Could you provide the diagrams in EPS/PDF, too? includesvg provides bad support on Windows and would be tricky on CI ... Otherwise, I'll use the PNG versions.

LinqLover commented 3 years ago

@codeZeilen Drafts are commited, but I need some EPS/PDF files before I can continue to align the Color-Buttons screenshots correctly ...

LinqLover commented 3 years ago

@codeZeilen Ready from my side, finally 😅