Closed phoeinx closed 1 year ago
@phoeinx Wow, this was a very detailed proof-reading! 👏
R1 (etoys examples): This was fixed via EToys-kfr.413 (Trunk). @codeZeilen Maybe should backport this to 5.3?
R2 (Color >> #asMorph
): Hm, we could choose another example, just for example, Bag >> #asMorph
to create a HistogramMorph
. However, it would be only a question of time until this gets implemented in the Trunk, too ... I'd suggest not "inventing" a new implementation in the book but only pointing to an existing one.
Re asMorph
: What about creating Rectangle>>asMorph
? Not the most useful Morph but not too much in danger of being implemented in the image.
R1 (etoys examples): This was fixed via EToys-kfr.413 (Trunk). @codeZeilen Maybe should backport this to 5.3?
I could not find this commit @LinqLover. Is it -eem.413.mcz?
R1 (etoys examples): This was fixed via EToys-kfr.413 (Trunk). @codeZeilen Maybe should backport this to 5.3?
I could not find this commit @LinqLover. Is it -eem.413.mcz?
Sorry, I was wrong. The discussion thread is here: http://forum.world.st/The-Inbox-EToys-kfr-412-mcz-tp5123571p5124254.html ReleaseBuilder support does not exist as of today.
Re
asMorph
: What about creatingRectangle>>asMorph
? Not the most useful Morph but not too much in danger of being implemented in the image.
Hm ... sounds pretty useful, too, when you are debugging some Morphic code and would like to get an impression where some bounds would actually be :-) I think I'd like to propose this to the inbox ...
I fixed the second issue.
The first issue is temporarily fixed by removing the passage from the text. However, I would prefer readding it later on.
The last one is the exact problem of mouse button mappings :) The world menu you opened is the wrong one...
well, ups. In my defense - the existence of two world menus is kinda confusing. :D
well, ups. In my defense - the existence of two world menus is kinda confusing. :D
I think you were totally right. The other menu is labeled the "old world menu" but the book only mentioned a "world menu", which in consequence must be the "new world menu". 🤯
I think we can mark issue 3 (wrong world menu) as done for now. In figure 1.3, the book explains correctly that the "normal" world menu is brought up via the red mouse button. IMHO this is not a problem with the book with the multiplicity of menus in Squeak. :-)
Ad R1 (viewer icons): This has been fixed in Squeak 6.0. However, I'm not sure whether we should introduce any Etoys concepts at all in the book, especially in this chapter. I'd opt for permanently removing this sentence (the current version of the book already refers to an explorer instead).
@codeZeilen Ad R1 (viewer icons): Currently, the example has been rewritten to describe an explorer instead of a viewer. Personally, I would vote for keeping it like this as I don't see the need to introduce Etoys concepts in the book. Also note that the original example works again in Squeak 6.0 and later.
tl;dr: Agree with closing this issue? :-)
Yes, in favor of closing this as Etoys concepts currently have no place in the book.
@LinqLover
I am proofreading Chapter 11: Morphic and am using the SWA20/21 image as my test image. (https://www.hpi.uni-potsdam.de/hirschfeld/artefacts/lecture-image/SWA2021.zip)
Reproducibility of examples:
[ ] R1. Page 222
[x] R2. Page 222
[x] R3. Page 224