[Proofreading] Chapter 11: Morphic - Style and Formatting

[phoeinx]

I am proofreading Chapter 11: Morphic and am using the SWA20/21 image as my test image. (https://www.hpi.uni-potsdam.de/hirschfeld/artefacts/lecture-image/SWA2021.zip)

Style / Formatting:

• S1. Page 223
  • 
    • if down is printed in italic, right should also be printed in italics
• S2. Page 223
  • 
  • two points is one to many :D
• S3. Missing points after figure descriptions.
  • Class 11.2
  • Class 11.20
  • Class 11.24
  • Class 11.27
• S4. Method information in figure descriptions
  • 
    • when named directly, as far as I can see, every method but horizontalBar and verticalBar have been identified with their Class in front like : SBECrossMorph>>drawOn:
• S5. Space before return value
  • as the space before return value is used as a convention in the other examples those few with out it don't fit
  • Method 11.12
  • Method 11.14
  • Methods 11.31
• S6. Exercises vs. only code descriptions
  • not really a problem but it feels kind of inconsistent
  • some provided code snippets come with a request to define / update etc. them oneself (identified by a squeak cat head before them). (E.g. Method 11.4) Others come with an description and saying how things can be done. (E.g. Method 11.5). I suppose the ones without an exercise aren't really necessary to follow the tutorial? But as this chapter feels like a - try every example - tutorial this for me personally just appeared a bit inconsistent.
• S7. Copy problems
  • When copying the code snippet on page 232 (11.17) what appears like a single dash turns out to be two dashes, thus leading to debugging in Squeak instead of just being able to run the code
  • 
  • "keyValue = $-- asciiValue"
• S8. Example abstraction levels
  • On page 244 Figure 11.6 provides an abstract explanation giving the method that one can use to get an Input Dialog, Figure 11.7 on the other hand provides a code sample which can be used directly.
  • 
• S9. Parameter Names
  • Method 11.23 is the only place where an incoming event parameter is named ev and not anEvent
  • 
• S10. Not using accessor methods
  • In Method 11.29 instance variables are set directly and not via accessor methods, which especially for faces: and dieValue: is weird, because we define those methods later on (and they do sensible sanity checks)
  • 

[codeZeilen]

Unsolved and migrated to a new issue afterwards:

S6. Exercises vs. only code descriptions

not really a problem but it feels kind of inconsistent
some provided code snippets come with a request to define / update etc. them oneself (identified by a squeak cat head before them). (E.g. Method 11.4) Others come with an description and saying how things can be done. (E.g. Method 11.5). I suppose the ones without an exercise aren't really necessary to follow the tutorial? But as this chapter feels like a - try every example - tutorial this for me personally just appeared a bit inconsistent.

S10. Not using accessor methods

In Method 11.29 instance variables are set directly and not via accessor methods, which especially for faces: and dieValue: is weird, because we define those methods later on (and they do sensible sanity checks)