search

hpi-swa-lab / godot-pronto

https://hpi-swa-lab.github.io/godot-pronto/
18 stars 4 forks source link

PrototypingUI does not update the values of ValueBehaviors in Spawners #161

Open leogeier opened 1 year ago

jgrenda commented 1 year ago

reproduction_failure @leogeier are there any reproduction examples?

tom95 commented 1 year ago

Connect a value_changed from the value to a Label's text. Changing the value does not change the text (yesterday at least :)).

JulianEgbert commented 1 year ago

I think with the current changes from Finn the Value gets changed. I tried this with the "game_car" example (updated version committed just now).

Those changes currently change the ValueBehaviors initial values during runtime, meaning that after playing the game, the previous values will also be overwritten by those changed during runtime.

jgrenda commented 1 year ago

#161_not_reproduced Can not reproduce at this point in time

tom95 commented 1 year ago

I've just re-checked, indeed the original description was incorrect: the update only does not occur if the ValueBehavior is in a Spawner (which makes sense, it willl only update the value for its offscreen template).

I would say the expectation is that the PrototypingUI will be aware of the fact that a ValueBehavior belongs to a Spawner's template and consequently updates all instances as well. I would be optimistic that this is comparatively easy to do, especially with @jgrenda 's recent changes?

(updated issue title to better reflect problem)