search

hpi-swa-lab / qinoq

Create wonderful scrollytellings inside of lively.next ❄
MIT License
2 stars 0 forks source link

Fontsize of labels changes to 0 #1019

Closed T4rikA closed 2 years ago

T4rikA commented 3 years ago

Describe the bug The size of labels became 0 in the user test

To Reproduce Steps to reproduce the behavior: not clear, try zooming the interactive and loading/ unloading it

frcroth commented 3 years ago

how can it be high and not reproducible

linusha commented 3 years ago

Probably related to #1013. The logic that scales the text is extremely primitive right now.

T4rikA commented 3 years ago

Yes, and it is high because this destroys the created scrollytelling and needs time to fix (go through every sequence, select morph and increase font size). I am not quit sure how it got to 0 and didn't become larger again

T4rikA commented 3 years ago

Also sometimes textscaling just doesn't work (text areas and labels)

linusha commented 2 years ago

The current implementation allows for the fontSize to become 0 when making the interactive smaller. Once it is 0, it will never become larger again, because the current fontSize is factor in the calculation of the new fontSize. Fixing this is easy, as one does only need to exchange the call to Math.round() with Math.ceil().

However, the scaling is also non-revertible at the moment. E.g. once one reaches a fontSize of 1, reverting the extent will lead to e..g, much larger text.

linusha commented 2 years ago

Fixed with 2f2c6bcc8c4d239a581d2bd561dc30fc67cb155b.