search

hpi-swa-lab / qinoq

Create wonderful scrollytellings inside of lively.next ❄
MIT License
2 stars 0 forks source link

Connections to OnScrollChange of the interactive are not removed #1047

Closed Paula-Kli closed 2 years ago

Paula-Kli commented 3 years ago

Describe the bug When removing something like a LottieMorph that has a OnScrollChange connected those connections on removal of the object are not correctly removed

frcroth commented 3 years ago

You mean when a developer has added a connection?

linusha commented 2 years ago

To reproduce:

  1. Create a new interactive
  2. Add a morph to it
  3. Connect onScrollChange of the Interactive with the newly added morph
  4. Delete the morph (e.g., by using the Trashcan-Halo)
  5. See the connection persisting in the attributeConnections of the interactive
linusha commented 2 years ago

This is rudimentary fixed in 30d18f653837cfa082838c73245064c9cc889214.