hpi-swa-lab / qinoq

Create wonderful scrollytellings inside of lively.next ❄
MIT License
2 stars 0 forks source link

Interactive morph onAbandon connection is not cleared after dragging interactive out of editor #710

Closed frcroth closed 3 years ago

frcroth commented 3 years ago

Which does not allow bundling

linusha commented 3 years ago

Just to make sure - you are on this branch? Because otherwise that is not surprising, as dragging morphs out of the interactive is not currently supported on dev.

frcroth commented 3 years ago

I don't know which branch Paula is on

On Mon, May 17, 2021 at 7:42 PM linusha @.***> wrote:

Just to make sure - you are on this https://github.com/hpi-swa-lab/qinoq/tree/feature/grabbing-morph-out-of-interactive branch? Because otherwise that is not surprising.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hpi-swa-lab/qinoq/issues/710#issuecomment-842510927, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABULXWBFSICVT7RJ37FM3RLTOFIQFANCNFSM45A2YCPQ .

Paula-Kli commented 3 years ago

no it is not about dragging morphs out of the interactive.. it is about morphs which are still in the interactive just grabbing the interactive out of the editor

linusha commented 3 years ago

If you know how to reproduce it let's check again after #697 is merged, ok? It might be #698, which was not only the case for the creation of connections, but also for how they were disconnected. This should be fixed in the same PR I'd hope. :slightly_smiling_face:

Paula-Kli commented 3 years ago

thinking about my interaction again @frcroth might have been right in the first place... I think we need to remove from the now created scrollytelling all connections and afterwards I can check again... there were strange things happening I am not sure about it anymore... sorry

linusha commented 3 years ago

This should be solved with #697. Please reopen again if that is not the case.