Check whether we want to update social media button through inspector

hpi-swa-lab / qinoq

Create wonderful scrollytellings inside of lively.next ❄

MIT License

2 stars 0 forks source link

Check whether we want to update social media button through inspector #965

Closed Paula-Kli closed 3 years ago

Paula-Kli commented 3 years ago

Closes #955

[ ] I have added additional features that should now be part of the PR template. I made the necessary changes to the template.
[x] I have fixed a bug/the added functionality should not be part of the PR template.
- [ ] I added a test/ tests.
[ ] I have run all our tests and they still work.

Paula-Kli commented 3 years ago

the problem was that on setting everything in the inspector those changes were propagated back to the social media button which was not intended I think

linusha commented 3 years ago

the problem was that on setting everything in the inspector those changes were propagated back to the social media button which was not intended I think

I am still not sure what this means, sorry :/

Paula-Kli commented 3 years ago

the problem was that on setting everything in the inspector those changes were propagated back to the social media button which was not intended I think

I am still not sure what this means, sorry :/

when selecting a social media button, the inspector needs to display the correct values. Lets say we have a Twitter button: we will now select that the button is a twitter button in the inspector. Selecting this settings propagated the changes back to the button which is not intended in my opinion