Feature/animated image loader

hpi-swa-teaching / GameMecha

A library providing implementations for common patterns in Squeak/Smalltalk game development.

MIT License

12 stars 2 forks source link

Feature/animated image loader #67

Closed benrobby closed 6 years ago

benrobby commented 6 years ago

implemented animatedImageLoader with tests and acceptance test. Also some other changes not concerning this (because i worked on the wrong branch).

tests for animatedImageLoader only run locally, not on travis since we were not able to store AnimatedImageMorphs or AnimatedGIFReadWriter on disk.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 445

44 of 44 (100.0%) changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.03%) to 86.298%

Totals
Change from base Build 442:	1.03%
Covered Lines:	359
Relevant Lines:	416

💛 - Coveralls

benrobby commented 6 years ago

resources are now created like all others on the fly

NiklasKoehnecke commented 6 years ago

why does the testrunslocally exist? Since we can create and save files now

NiklasKoehnecke commented 6 years ago

made some minor refactorings but it wont let me push. Tests that are marked as "not covered" are actually covered, so idk. Pushed from Command prompt, hope that nothing broke