hpi-swa-teaching / IMAPClient

This project provides a library and tool set to access email through IMAP in the Squeak/Smalltalk environment. (SWT22-13)
MIT License
22 stars 3 forks source link

Refactor tests related to ICEndpointCommandTest #360

Open JuliaJoch opened 4 years ago

JuliaJoch commented 4 years ago

The tests of ICEndpointCommandTest and several other older Test Classes have so many test smells that we are overwhelmed by all the changes that would be necessary in order to make this readable.

For example there is code duplication for setting up the email objects that will be tested which could be refactored into the setup method. Also there are tests with a lot of assertions in one method.

MrHenrik commented 4 years ago

In addition the tearDown in ICEndpointCommandTest does not delete the folders which it builds