coveralls
commented
3 years ago Pull Request Test Coverage Report for Build 1008403859
- 16 of 24 (66.67%) changed or added relevant lines in 7 files are covered.
- 10 unchanged lines in 2 files lost coverage.
- Overall coverage decreased (-0.5%) to 77.961%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| packages/IMAPClient-Core.package/ICConnectionHandler.class/instance/select..st | 0 | 1 | 0.0% | ||
| packages/IMAPClient-Core.package/ICEndPoint.class/instance/connectAndLogin.st | 0 | 3 | 0.0% | ||
| packages/IMAPClient-Core.package/ICEndPoint.class/instance/readEmailsFromDisk.st | 0 | 4 | 0.0% | ||
| <!-- | Total: | 16 | 24 | 66.67% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| packages/IMAPClient-Core.package/ICConnectionHandler.class/instance/select..st | 3 | 0% | ||
| packages/IMAPClient-Core.package/ICConnectionHandler.class/instance/throwErrorIfAccountInvalid.st | 7 | 0% | ||
| <!-- | Total: | 10 | --> |
| Totals | |
|---|---|
| Change from base Build 993052216: | -0.5% |
| Covered Lines: | 1132 |
| Relevant Lines: | 1452 |
elenagensch
sm1lla
laugengebaeck
What does this change?
[Feature] Adds the possibility to access offline mode of IMAP Client without being logged in.
Splits Login Process from ICFolderDialog initialization. Emails and Folders are loaded from File Storage (structure from last synchronization). Uses the UIManager for password request. Layered structure for calls from UI to interface with returns implemented. Bugs for login fixed (fatal error extracted from login process). Closes #409 and closes #410
Co-authored-by: Elena Gensch elena.gensch@student.hpi.de Co-authored-by: Jan Groeneveld jan.niklas.groeneveld@gmail.com
Decisions / Choices I made
We removed the Password Dialog, as it oppposes the layered structure of handling requests and there's a lot of logic (passing arround FolderDialog instance, defining button) just for retrieving the password. Uses UIManager instead.
Checklist