search

hpi-swa-teaching / MensaWidget

Mensa Widget
MIT License
2 stars 0 forks source link

52 network error handling #63

Closed Kangaroo6942 closed 2 months ago

Kangaroo6942 commented 3 months ago

Added error handling for a missing network connection and implemented a test.

Kangaroo6942 commented 3 months ago

I don't think it's that much of a problem, since it allows for more interchangebility anyway. Otherwise we temporarily would have to overwrite the methods of WebClient which Squeak won't let me do.

Kangaroo6942 commented 2 months ago

Regarding the test... I think that is out of scope for the MWApiWrapper test specifically. A failure in this test could indicate that something is wrong somewhere in the chain of calls and returned objects, but via the test, you can't easily determine where the error occurred. As long as we test the components individually I'd say we're fine