#82 refactor route handling

hpi-swa-teaching / RatPack2.0

Other

0 stars 2 forks source link

#82 refactor route handling #101

Closed essal0815 closed 6 years ago

essal0815 commented 6 years ago

fixes #82

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 280

37 of 37 (100.0%) changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.7%) to 73.129%

Totals
Change from base Build 268:	0.7%
Covered Lines:	762
Relevant Lines:	1042

💛 - Coveralls

richardebeling commented 6 years ago

A quick notice: Github has Keywords that connect pull requests and issues. When you write fixes #issue somewhere in the PR, the issue will be closed when the PR is accepted and github shows nice linkage between them. We should use that. I added the comment to your first post.

essal0815 commented 6 years ago

If checks pass, shall I merge ?

richardebeling commented 6 years ago

From my side, yes