Hardcoded copies of globalMiddlewareKey (#globalMiddleware) [3]

[richardebeling]

Subject

The symbol #globalMiddleware is used in various places where RPApplication>> settings>> globalMiddlewareKey should be used

Details

During development, we had different places where we had no easy way to access the user-configured globalMiddlewareKey, so we just hardcoded #globalMiddleware there. I think we wanted to remove the setting afterwards, but we didn't do so. Currently, everything will break if you change the globalMiddlewareKey in the settings.

Tasks / Acceptance Criteria

• [ ] Either use #globalMiddleware everywhere in the project and remove the setting or use the setting in all places

Efford estimation

1. To just use #globalMiddleware everywhere: 3
2. To search a way to use globalmiddlewareKey, and then find out it's not really possible and use approach 1: 8.

[ninaihde]

5

[skydivin4ng3l]

1. 3
2. 10 for me it is not totally clear how the globalmiddlewarekey is supposed to be used. maybe it gets clearer when I look into the code again

[richardebeling]

Tom advised us to use the simple way of using #globalMiddleware everywhere

[richardebeling]

since the semester is over now, we will not fix this. Leaving the issue open for the next group working on this.