search

hpi-swa-teaching / SVGMorph

(SWT22-04)
MIT License
5 stars 2 forks source link

Off-By-One errors in bounds for Circle and Group #80

Open dasGoogle opened 2 years ago

dasGoogle commented 2 years ago

As a User, I expect the bounds of SVG elements to be calculated correctly in order to handle onClick events and other calculations correctly.

Currently, all bounds of circles and groups have an off by one error.

See these tests for an example: SVGMorphTest>>testSVGCircleBounds

SVGMorphTest>>testSVGGroup

These tests are currently marked as expectedFailures. To test, them, you have to re-enable them.