search

hpi-swa-teaching / SketchMorph2

(SWT22-06)
MIT License
5 stars 1 forks source link

Use MTF for tests #46

Closed ClFeSc closed 3 years ago

ClFeSc commented 3 years ago

Closes #45

ClFeSc commented 3 years ago

My plan is to first move all tests to the new class. I already marked some tests as questionable, feel free to point out more such tests.

ClFeSc commented 3 years ago

@maximilian-franz

Some files have two dots before the file ending, e.g. baseline..st.

Sure. What's the problem with them?

Also, should we insert a newline at the end of a .st file (as suggested by github)?

I agree. I will add them to all files of the MorphicMonetTests class, the other files are out of scope of this PR, I think.

maximilian-franz commented 3 years ago

@ClFeSc

Sure. What's the problem with them?

It's not necessarily a problem, it just looks a bit weird (at least to me).

ClFeSc commented 3 years ago

@maximilian-franz

It's not necessarily a problem, it just looks a bit weird (at least to me).

I'm not sure if you know this, but Squeak uses . in file names wherever a : in the method signature is. So the file for the method baseline: will get the name baseline., which is then appended to .st, thus creating baseline..st. I don't think there is much we can do about it.

maximilian-franz commented 3 years ago

@ClFeSc

I'm not sure if you know this, but Squeak uses . in file names wherever a : in the method signature is. So the file for the method baseline: will get the name baseline., which is then appended to .st, thus creating baseline..st. I don't think there is much we can do about it.

Ah ok, I didn't know that.