hpi-swa-teaching / SketchMorph2

(SWT22-06)
MIT License
5 stars 1 forks source link

Add text tool #64

Closed ClFeSc closed 3 years ago

ClFeSc commented 3 years ago

Closes #35

ClFeSc commented 3 years ago

The test testSimpleText is known to fail. This will be fixed.

kpostnov commented 3 years ago

Without having looked at the code yet, UiFugueIcons >> editIcon seems like a more fitting icon for the text tool.

kpostnov commented 3 years ago

I don't know if it's just me but, in comparison to other branches, something is affecting the performance while drawing. Might be something to take a closer look at.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 900165383

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/SketchMorph2-Core.package/M2Backend.class/instance/toggleFillGeometricForm.st 0 1 0.0%
packages/SketchMorph2-Core.package/MorphicMonet.class/instance/chooseColor.st 0 1 0.0%
packages/SketchMorph2-Core.package/M2Backend.class/instance/chooseFont.st 0 3 0.0%
<!-- Total: 194 199 97.49% -->
Totals Coverage Status
Change from base Build 895514137: 2.6%
Covered Lines: 1015
Relevant Lines: 1235

💛 - Coveralls
ClFeSc commented 3 years ago

We currently have the problem that, when moving MorphicMonet, one can see the temporaryTextMorph floating around in the Image, approx. -100 asPoint away from the top left corner of the Canvas.

DevSchmidtchen commented 3 years ago

We currently have the problem that, when moving MorphicMonet, one can see the temporaryTextMorph floating around in the Image, approx. -100 asPoint away from the top left corner of the Canvas.

This temporary placement at -100 asPoint looks a bit tacky to me. Isn't there another way of hiding the morph at the beginning and between (for example deleting it and only creating it if used)?

kpostnov commented 3 years ago

When clicking the Choose Font - button while having the text tool activated it is possible to draw on the canvas even though only writing text should be allowed.

ClFeSc commented 3 years ago

When clicking the Choose Font - button while having the text tool activated it is possible to draw on the canvas even though only writing text should be allowed.

Should be fixed.