Closed ClFeSc closed 3 years ago
The test testSimpleText
is known to fail. This will be fixed.
Without having looked at the code yet, UiFugueIcons >> editIcon
seems like a more fitting icon for the text tool.
I don't know if it's just me but, in comparison to other branches, something is affecting the performance while drawing. Might be something to take a closer look at.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
packages/SketchMorph2-Core.package/M2Backend.class/instance/toggleFillGeometricForm.st | 0 | 1 | 0.0% | ||
packages/SketchMorph2-Core.package/MorphicMonet.class/instance/chooseColor.st | 0 | 1 | 0.0% | ||
packages/SketchMorph2-Core.package/M2Backend.class/instance/chooseFont.st | 0 | 3 | 0.0% | ||
<!-- | Total: | 194 | 199 | 97.49% | --> |
Totals | |
---|---|
Change from base Build 895514137: | 2.6% |
Covered Lines: | 1015 |
Relevant Lines: | 1235 |
We currently have the problem that, when moving MorphicMonet, one can see the temporaryTextMorph
floating around in the Image, approx. -100 asPoint
away from the top left corner of the Canvas.
We currently have the problem that, when moving MorphicMonet, one can see the
temporaryTextMorph
floating around in the Image, approx.-100 asPoint
away from the top left corner of the Canvas.
This temporary placement at -100 asPoint
looks a bit tacky to me. Isn't there another way of hiding the morph at the beginning and between (for example deleting it and only creating it if used)?
When clicking the Choose Font - button while having the text tool activated it is possible to draw on the canvas even though only writing text should be allowed.
When clicking the Choose Font - button while having the text tool activated it is possible to draw on the canvas even though only writing text should be allowed.
Should be fixed.
Closes #35