search

hpi-swa / Ohm-S

A Squeak/Smalltalk implementation of the metaprogramming framework Ohm.
MIT License
24 stars 8 forks source link

Remove length limitation of the binarySelector in the grammar #36

Closed bdaase closed 5 years ago

bdaase commented 5 years ago

The implementation of the parser in Squeak 5.2 does not care about the length of binarySelectors. That means, that you could create a method with e.g. the selector @@@@@ and call it which results in a proper execution of the method. Also, older versions of the SHParserST80>>parseBinary method do not show any limitation.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.009%) to 84.624% when pulling d8bc76eb419beaae55ead898c7f691b6910855b8 on BjoernDaase:master into bdfb2230d40125dd51861321ad281132ecf8d28f on hpi-swa:master.

bdaase commented 5 years ago

@codeZeilen I also updated the corresponding test now.

codeZeilen commented 5 years ago

I will merge this now and fix a minor issue in the serialization of the test method afterwards.