search

hpi-swa / Ohm-S

A Squeak/Smalltalk implementation of the metaprogramming framework Ohm.
MIT License
24 stars 8 forks source link

Add methods for detecting nodes with invalid intervals #56

Closed felixauringer closed 4 years ago

felixauringer commented 4 years ago

I added methods to check whether an OhmNode has no content. If that is the case, it is safe to ignore the node and its children when building the source map. This prevents all index out of bounds errors in the source map that we have found so far (all our comment-tests are green with this branch).

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.03%) to 85.273% when pulling df84068adc57b17aae3dfc66256f88cde77d2553 on felixauringer:bugfix/swt-submission into d7f2ac858e1ec028b9bf2e8f62f3710b99ee6ce6 on hpi-swa:new-whitespace-handling.

felixauringer commented 4 years ago

I'll delete this PR because the branch name contains a / and the smalltalk CI cannot handle that so we created a new branch.