hpi-swa / RSqueak

A Squeak/Smalltalk VM written in RPython.
BSD 3-Clause "New" or "Revised" License
83 stars 15 forks source link

Link images with new git lfs? #111

Open j4yk opened 8 years ago

j4yk commented 8 years ago

https://github.com/blog/2069-git-large-file-storage-v1-0

Would it be interesting to add sample images to the repo or externalize some test images with this new facility?

krono commented 8 years ago

sounds good

fniephaus commented 8 years ago

GitHub's Git LFS service is pretty limited: https://help.github.com/articles/billing-plans-for-git-large-file-storage/#storage-limits

I'd suggest to use our artefacts repository instead.

fniephaus commented 8 years ago

I've ran some experiments and using the bfg repo-cleaner, I was able to reduce the total size of the repository by 695M (from 831.8M to 136.8M). Here's the command I used:

bfg --delete-folders images <git repo>

It seems that random 4.5/4.6 images in ./images (which has been in .gitignore for some time now) are accountable for those 695M. Not sure if we want to rewrite the entire history because of that though.

timfel commented 8 years ago

@fniephaus that cleanup might be nice to have (as long as the current master's project can still rebase their branch onto the rewritten history). Since we now produce app bundles, i don't think the small images in the test folders are that bad, and I'm not planning on adding more images

fniephaus commented 8 years ago

I don't think bfg breaks branches, so we should be fine. While we are at it, we could also put the test images somewhere where they can be downloaded as dependency, but let's talk about this tomorrow :)