hpi-swa / RSqueak

A Squeak/Smalltalk VM written in RPython.
BSD 3-Clause "New" or "Revised" License
83 stars 15 forks source link

Added missing @not_rpython #148

Closed smarr closed 6 years ago

smarr commented 6 years ago

This fixes a compilation issue observed here:

https://travis-ci.org/smarr/are-we-fast-yet/jobs/319877528#L826

At least I hope it does.

krono commented 6 years ago

Looks good. maybe @untranslated_cmd should also imply @not_rpython.. but lets see where this goes first

smarr commented 6 years ago

Looks like travis builds are broken:

$ .travis/success.sh
curl: Can't open 'rsqueak-64bitraspbian*'!
curl: try 'curl --help' or 'curl --manual' for more information
Enter host password for user '':
krono commented 6 years ago

Yeah, but that looks unrelated.

smarr commented 6 years ago

My build is still failing with this change https://travis-ci.org/smarr/are-we-fast-yet/jobs/319947764

krono commented 6 years ago

Ok. I have a hunch that it is because you actually run build.py from the .build dir. See https://github.com/smarr/are-we-fast-yet/pull/39

krono commented 6 years ago

Scratch that, didn't help…

smarr commented 6 years ago

Yeah, no, seems unrelated, tried it here: https://travis-ci.org/smarr/are-we-fast-yet/jobs/319962314#L825 https://github.com/smarr/are-we-fast-yet/commit/f06dd3a1cc6045441a6658eb7c6681a3b77ef203

on https://github.com/smarr/are-we-fast-yet/tree/fix-travis

krono commented 6 years ago

k