hpi-swa / Squot

Squeak Object Tracker - Version control for arbitrary objects, currently with Git storage
Other
60 stars 29 forks source link

Unify "skip this change" and "toggle whether this will be loaded" #329

Closed LinqLover closed 3 years ago

LinqLover commented 3 years ago

The triple brackets are a little bit confusing to me:

image

When I select the last line in the screenshot and press cmd + x, I would have expected to un-ignore it and thus load the package when I press Accept.

j4yk commented 3 years ago

What do you mean by "unify"? These are two different things: skip this change will prevent that changes are applied to an artifact, which might be unloaded, while toggle load controls whether the artifact will be loaded afterwards.

If "choose this edition" would also turn on load, you could not toggle it back and forth for an unloaded artifact (think of a -Pharo platform package or so...).

LinqLover commented 3 years ago

Thank you, I was not aware of the different meanings. The double brackets were just a bit confusing to me. :-)