hpi-swa / Squot

Squeak Object Tracker - Version control for arbitrary objects, currently with Git storage
Other
58 stars 29 forks source link

Sublime Merge UI #376

Open marceltaeumel opened 2 years ago

marceltaeumel commented 2 years ago

I like the user interface of Sublime Merge. Especially the right side where you can stage or discard changes before the commit. It's not a series of dialogs but an integrated workflow with stable screen contents. The granularity of changed files and hunks within files matches the packages/classes/methods in Squeak.

The GitBrowser has such an overview already in the commit dialog text pane. Yet, you cannot ignore or discard anything in that view. Instead, you have to interact with the tree view on the left. Maybe we could use text actions to make that text box showing diffs more interactive?

j4yk commented 2 years ago

From what I can see it seems to offer similar features to those that SourceTree has already offered for several years, haha.

Here are the characteristics I noticed for the right side of Sublime Merge's main window:

Please add any others that you find noteworthy.

Note that the Git Browser tools do not use the concept of staging. Instead it follows the Gitless way of life of "including" and "excluding" differences on demand and to include every change into new commits by default.

So in essence it is about being able to invoke the exclude and include actions from the text view on the right side of the commit dialog, rather than having to "go back" to the tree view on the left side after you have spotted a difference that you would like to exclude, correct?

LinqLover commented 1 year ago

So in essence it is about being able to invoke the exclude and include actions from the text view on the right side of the commit dialog, rather than having to "go back" to the tree view on the left side after you have spotted a difference that you would like to exclude, correct?

Plus the option to revert/discard unintended changes from the save dialog, I think? Personally, I'm also still in favor of the unfinished approach in https://github.com/hpi-swa/Squot/tree/swa-chooseAnother which could allow you to just press cmd + s in the diff pane to accept a new source for the commit.

j4yk commented 1 year ago

But reverting from the save dialog is a different feature: https://github.com/hpi-swa/Squot/issues/286 And so is the edit-merge-in-place feature in that ~pull request~ branch https://github.com/hpi-swa/Squot/issues/339 :-)