hpi-swa / sandblocks

A projectional editor for Squeak/Smalltalk.
MIT License
35 stars 3 forks source link

SBStTestCase: Update history and honor expected failures #107

Closed LinqLover closed 2 years ago

LinqLover commented 2 years ago

babylonian/core: dispatch SBStTestCase results into history (7faf6ab82aacabaf0f43252114ddbd73c278f0ae)

This change is visible when you run an SBStTestCase from a browser editor. In the past, the test result icon in the containing browser's message list would not have been updated (as compared to running the same test via the message list menu > "run test") - now this works. See also: CodeHolder>>#testRunSuite:.

sandblocks-test-update-history

babylonian: indicate expected failures and unexpected passes for tests (4d9f569b4bf8f42b697946b5e87c1ba009f03e2c)

image

⚠️ Please report back whether you like this display. An alternative would be compound icons (such as ✔️⚠️ or ❌✔️) with an explaining tool tip. I'm not sure what gives the best UX.

core: robustize clipboard test #tearDown against previously empty clipboard

Nit.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1924513727

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 1922503786: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls
tom95 commented 2 years ago

Great changes, thank you! And please excuse the long delay, it seemed to have escaped my attention :/

LinqLover commented 2 years ago

No problem, thank you!