hpi-swa / sandblocks

A projectional editor for Squeak/Smalltalk.
MIT License
35 stars 3 forks source link

Suggestion improvements (2) #111

Open LinqLover opened 2 years ago

LinqLover commented 2 years ago

This PR proposes further improvements, new hooks, and some fixes to the suggestions infrastructure. Depends on (and includes) #108.

st/core: dispatch gathering of completion suggestions to containingArtefact for specialization (ab393e3)

For instance, sonyx overrides some of these new 'artefactCompletion' hooks in order to minimize the selector list, add custom selectors, or insert instances from a subclass of SBSuggestionItem.

image image

Video (πŸ”Š):

https://user-images.githubusercontent.com/38782922/156855690-2aef301b-2bc3-44f7-9165-c481846569e3.mp4

Open issues on this change:

st/core: provide hook Class>>#sandblocksMetaSuggestionsFor: (5f84560)

For instance, you could override the hook like this on Color to prioritize color names:

sandblocksMetaSuggestionsFor: aBlock

    ^ self colorNames, (super sandblocksMetaSuggestionsFor: aBlock)

Sonyx makes use of this hook, too.

misc

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1936438058

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 1922503786: 0.0%
Covered Lines: 0
Relevant Lines: 0

πŸ’› - Coveralls