Open LinqLover opened 2 years ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Totals | |
---|---|
Change from base Build 1922503786: | 0.0% |
Covered Lines: | 0 |
Relevant Lines: | 0 |
This PR proposes further improvements, new hooks, and some fixes to the suggestions infrastructure. Depends on (and includes) #108.
st/core: dispatch gathering of completion suggestions to
containingArtefact
for specialization (ab393e3)For instance, sonyx overrides some of these new 'artefactCompletion' hooks in order to minimize the selector list, add custom selectors, or insert instances from a subclass of
SBSuggestionItem
.Video (π):
https://user-images.githubusercontent.com/38782922/156855690-2aef301b-2bc3-44f7-9165-c481846569e3.mp4
Open issues on this change:
SBStContainer
. However, this is not necessarily the single truth. Maybe alternatively/additionally dispatch the creation via the editor, the grammar handler, or a completely new entity?st/core: provide hook
Class>>#sandblocksMetaSuggestionsFor:
(5f84560)For instance, you could override the hook like this on
Color
to prioritize color names:Sonyx makes use of this hook, too.
misc
core: fix
SBSuggestionMenu>>#sandblockEditor
(544932d)The menu is not a sub*morph of the editor, so we need to use the instvar here.
core: fix dismissal of suggestions menu via click if
#suggestAlways
is true (ac89fb4)