search

hpi-swa / sandblocks

A projectional editor for Squeak/Smalltalk.
MIT License
35 stars 3 forks source link

Fix usage of `#inheritsFrom:` #46

Closed LinqLover closed 3 years ago

LinqLover commented 3 years ago

Show the Morph palette for methods located in the Morph class itself, too, as opposed to its super+classes only. Implement #includesBehavior: on SBStClass next to #inheritsFrom:, just in case. Minor refactoring.

LinqLover commented 3 years ago

@tom95 For sake of completeness: I don't know about their exact meaning, but should these match methods maybe also use #includesBehavior: instead of #inheritsFrom:?

image

tom95 commented 3 years ago

Hey, thanks for the fixes!

The other methods you pointed out are both set up on top of a legacy representation matching system. I would migrate them to the new system at a later point when the experiments become relevant again, so no fixes necessary here otherwise I would say :)

LinqLover commented 3 years ago

Alright, thanks for the fast review! :-)