search

hpi-swa / sandblocks

A projectional editor for Squeak/Smalltalk.
MIT License
35 stars 3 forks source link

Type-sensitive suggestion arg names #86

Closed LinqLover closed 2 years ago

LinqLover commented 2 years ago

st: honor guessed class for mining of possible argument names

Testing:

Morph new click: ...
ListStub new click: ...

The argument name should be chosen from the right implementation preferably. The previous detection mechanism proposed to wrong name.

However, this solution is still not perfect IMHO. Depending on the situation, less confusion might be caused by eliminating the second pass via #systemNavigation entirely, i.e., providing no custom argument names at all if type guessing failed. Wdyt?

Also, what would be a proper place to eliminate the duplication between SbStNewMessageSend and SBStSignature?

LinqLover commented 2 years ago

With some delay, thank you for the review, the explanation & merging his!

Since this now has been live for some time, did you notice any performance issues due to https://github.com/hpi-swa/sandblocks/pull/86#discussion_r786273024?