Before using Metacello>>onConflictUseIncoming, check if its there.

hpi-swa / smalltalkCI

Framework for testing Smalltalk projects with GitHub Actions, GitLab CI, Travis CI, AppVeyor, and others.

MIT License

96 stars 68 forks source link

Before using Metacello>>onConflictUseIncoming, check if its there. #526

Closed theseion closed 3 years ago

theseion commented 3 years ago

This method doesn't exist in the Metacello versions loaded into Pharo 3 and 4. Instead, we can use #onConflict: directly

fniephaus commented 3 years ago

Mh, should we maybe add a Pharo 3 build to our build matrix?

theseion commented 3 years ago

Depends... I seem to be the only one testing those :). My two cents: do it if it's a simple change and doesn't add any significant build costs. Otherwise I wouldn't bother.

fniephaus commented 3 years ago

I've added a couple of more images to the build matrix: https://github.com/hpi-swa/smalltalkCI/commit/9bbacfa012d8ec7e00996c880147af51ff42d573

Should be ok for now :)